Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deprecated syntax #30

Closed

Conversation

simoebenhida
Copy link

@simoebenhida simoebenhida commented Apr 8, 2020

The below syntax is deprecated and it doesn't also work on Safari 12.

pc.setRemoteDescription(sessionDescription, successCallback, errorCallback);

You can check it here: https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/setRemoteDescription

@jenkinskurento
Copy link
Contributor

@jenkinskurento jenkinskurento commented Apr 8, 2020

Hi there, thanks for your Pull Request!

A Kurento member needs to verify that this patch is reasonable to test. In case it is, they should write a comment with the phrase test this please. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by Kurento members will still work. Regular contributors can be whitelisted to skip this step.

@j1elo
Copy link
Member

@j1elo j1elo commented Jun 9, 2020

Closed by #32
(same fix applied)

Thanks!

@j1elo j1elo closed this Jun 9, 2020
@simoebenhida
Copy link
Author

@simoebenhida simoebenhida commented Jun 9, 2020

@j1elo It will be cool if you merge the old MRs first next time 😀

@j1elo
Copy link
Member

@j1elo j1elo commented Jun 9, 2020

Agree, sorry! I was asked to attend the other PR, so I focused my work on there.
Still, when fixing this I made sure to add both to the Thank You section of the next Release Notes. This PR did an important work in letting me know what was the minimal change needed to achieve the fix, so thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants