Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecorderEndpoint: Parse and use username/password from URLs #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RecorderEndpoint: Parse and use username/password from URLs #44

wants to merge 1 commit into from

Commits on Jun 13, 2023

  1. server: RecorderEndpoint/UriEndpoint parse username/password from URLs 

    Use GstUri to parse the destination URL and extract the
username:password field (called "userinfo").

Then, split the userinfo from the colon (:).

Lastly, URL-decode each of the resulting parts.

NOTE: GStreamer 1.16 (Ubuntu 20.04) does NOT support extracting a
URL-encoded userinfo field. This means that the username and password
will be already decoded, and the splitting on ":" will happen at the
first colon found, which won't work if the username itself had a colon.

So, until we update to a newer Ubuntu/GStreamer version,
THE USERNAME CANNOT CONTAIN A COLON.

Also delete the unneeded function kms_is_valid_uri()`. Better to
delegate that check to the GstUri class constructor, which validates the
URI and ecides if it is valid or not.
    @j1elo
    j1elo committed Jun 13, 2023
    Configuration menu
    Copy the full SHA
    b8365d6 View commit details
    Browse the repository at this point in the history