Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement(langserver): Add find references api #226

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

my-vegetable-has-exploded
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kusionstack/KCLVM/kclvm/tools/src/langserver

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

see more in issue212

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

kclvm/tools/src/langserver/WordMap.rs Outdated Show resolved Hide resolved
kclvm/tools/src/langserver/tests.rs Outdated Show resolved Hide resolved
kclvm/tools/src/langserver/WordMap.rs Outdated Show resolved Hide resolved
@Peefy
Copy link
Contributor

Peefy commented Oct 8, 2022

@my-vegatable-has-exploded Pls sign the CLA and resolve the merge conflict.

@my-vegetable-has-exploded
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@coveralls
Copy link
Collaborator

coveralls commented Oct 27, 2022

Pull Request Test Coverage Report for Build 3336910371

  • 337 of 385 (87.53%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-29.9%) to 59.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/langserver/go_to_def.rs 0 3 0.0%
kclvm/tools/src/langserver/mod.rs 81 93 87.1%
kclvm/tools/src/langserver/word_map.rs 73 85 85.88%
kclvm/tools/src/langserver/find_refs.rs 0 21 0.0%
Totals Coverage Status
Change from base Build 3334066564: -29.9%
Covered Lines: 21022
Relevant Lines: 35333

💛 - Coveralls

kclvm/tools/src/langserver/mod.rs Show resolved Hide resolved
kclvm/tools/src/langserver/mod.rs Show resolved Hide resolved
kclvm/tools/src/langserver/go_to_def.rs Outdated Show resolved Hide resolved
kclvm/tools/src/langserver/find_refs.rs Outdated Show resolved Hide resolved
Peefy
Peefy previously approved these changes Nov 7, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Use position in kclvm-error in langserver.

Implement word_at_pos and tests

Add more comment for langserver.
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcl-lang kcl-lang unlocked this conversation Nov 8, 2022
@my-vegetable-has-exploded my-vegetable-has-exploded changed the title Find refs Enhancement(langserver): Add find references api Nov 8, 2022
@Peefy Peefy merged commit 71b3657 into kcl-lang:main Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants