[WIP] Feat : Support Call Kclvm Cli by C API #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
16 tasks
|
I have read the CLA Document and I hereby sign the CLA |
NeverRaR
changed the title
Peefy
added
api
Pull Request Test Coverage Report for Build 2744948016
💛 - Coveralls |
Peefy
reviewed
Jul 27, 2022
chai2010
reviewed
Jul 27, 2022
16 tasks
NeverRaR
force-pushed
the
dev/cdylib
branch
2 times, most recently
from
69feebd
to
41686fb
Compare
chai2010
reviewed
Jul 29, 2022
| @@ -0,0 +1,25 @@ | |||
| #pragma once | |||
| #ifndef KCLVM_SERVICE_CALL | |||
| #define KCLVM_SERVICE_CALL | |||
There was a problem hiding this comment.
#define __KCLVM_SERVICE_CALL_H__
16 tasks
Peefy
reviewed
Jul 29, 2022
Peefy
reviewed
Jul 29, 2022
Peefy
reviewed
Jul 29, 2022
| version = "0.1.0" | ||
| edition = "2021" | ||
|
|
||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html |
| } | ||
| } | ||
|
|
||
| pub fn ping(serv: &mut KclvmService, args: &[u8]) -> *const c_char { |
There was a problem hiding this comment.
more documents on Rust public functions.
| .into_raw() | ||
| } | ||
|
|
||
| pub fn exec_program(serv: &mut KclvmService, args: &[u8]) -> *const c_char { |
There was a problem hiding this comment.
more documents on Rust public functions.
| } | ||
| } | ||
|
|
||
| pub fn exec_program(&self, args: &ExecProgram_Args) -> ExecProgram_Result { |
There was a problem hiding this comment.
exec_program API and CLI implementation and error handling need to be considered uniformly,
Peefy
reviewed
Jul 29, 2022
| result.yaml_result = yaml_result; | ||
| } | ||
| } | ||
| result |
There was a problem hiding this comment.
Put error message in result.
Peefy
reviewed
Aug 1, 2022
| @@ -35,7 +35,7 @@ do | |||
| sslpath=$(brew --prefix openssl@1.1) | |||
| fi | |||
|
|
|||
| if [ x"$(uname -m)" == x"arm64" ]; then | |||
| if [ x"$(uname -m)" == x"arm64" ] || [ x"$(uname -m)" == x"x86_64" ]; then | |||
There was a problem hiding this comment.
U can rebase main branch to solve this
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re Feature : C API for Kclvm Cli #125
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
KCLVM/kclvm/src/api_test.rs
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.