Fix(kclvm-runner): Added different file locks depending on the curren… #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3408750725
💛 - Coveralls |
|
A quite basic and simple rule for any bug fix: you MUST write good tests for what you fix and prevent future errors. |
16 tasks
…tly package. If the current package is the main package, the lock will lock a temporary file based on time and process id. If the current package is not the main package, the lock will lock a file named 'package_path.ll.lock'. issue #270.
Peefy
reviewed
Nov 7, 2022
kclvm/runner/src/test_datas/multi_file_compilation/large_scale_case/main.k
Outdated
Show resolved
Hide resolved
|
LGTM |
ldxdl
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
issue #270.
2. What is the scope of this PR (e.g. component or file name):
kclvm-runner
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
Added different file locks depending on the currently package.
If the current package is the main package, the lock will lock a temporary file based on time and process id.
If the current package is not the main package, the lock will lock a file named 'package_path.ll.lock'.
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.