-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manifests.yaml_stream impl at kclvm runtime. #285
Conversation
Pull Request Test Coverage Report for Build 3458664862
💛 - Coveralls |
More UI test cases are needed with the new sys lib function. |
Right! The main change of this PR is the implementation of the runtime function. More language UI implementations and test cases need to be completed in another PR by @zong-zhe |
More options to consider and support:
|
90c4310
to
8b045a8
Compare
This is a good suggestion. I have added some of the options, and some of them left todo because |
8b045a8
to
e53a671
Compare
e53a671
to
d75c480
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
feat: #94
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.