Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate old core api pkg, use latest instead #1004

Merged
merged 1 commit into from Apr 6, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 5, 2024

What type of PR is this?

/kind chore

What this PR does / why we need it:

deprecate old core api pkg, use latest api.kusion.io instead

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added this to the v0.12.0 milestone Apr 5, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8577813920

Details

  • 108 of 199 (54.27%) changed or added relevant lines in 22 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 57.993%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/preview/options.go 4 5 80.0%
pkg/engine/operation/diff.go 0 1 0.0%
pkg/engine/operation/parser/spec_parser.go 0 1 0.0%
pkg/modules/generators/ordered_resources_generator.go 5 6 83.33%
pkg/modules/util.go 10 11 90.91%
pkg/cmd/generate/generator/generator.go 0 2 0.0%
pkg/modules/generators/app_configurations_generator.go 4 6 66.67%
pkg/modules/generators/workload/job_generator.go 5 7 71.43%
pkg/cmd/apply/options.go 5 8 62.5%
pkg/engine/spec/storages/local.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/modules/util.go 1 83.19%
Totals Coverage Status
Change from base Build 8571845224: -1.0%
Covered Lines: 7154
Relevant Lines: 12336

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit b38c5f3 into KusionStack:main Apr 6, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants