Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: preview&apply cmd implementation follow the command cmd pattern #1006

Merged
merged 1 commit into from Apr 14, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Apr 8, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Apr 8, 2024
@adohe adohe added this to the v0.12.0 milestone Apr 8, 2024
@coveralls
Copy link

coveralls commented Apr 8, 2024

Pull Request Test Coverage Report for Build 8679405118

Details

  • 212 of 406 (52.22%) changed or added relevant lines in 4 files are covered.
  • 49 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-1.5%) to 55.512%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/cmd.go 0 2 0.0%
pkg/cmd/meta/meta.go 0 10 0.0%
pkg/cmd/preview/preview.go 62 132 46.97%
pkg/cmd/apply/apply.go 150 262 57.25%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/generate/generator/generator.go 9 0.0%
pkg/cmd/apply/apply.go 9 55.35%
pkg/cmd/preview/preview.go 9 43.97%
pkg/cmd/generate/generate.go 21 0.0%
Totals Coverage Status
Change from base Build 8679391272: -1.5%
Covered Lines: 6828
Relevant Lines: 12300

💛 - Coveralls

@adohe adohe changed the title WIP: refact preview command refact: preview&apply cmd implementation follow the command cmd pattern Apr 12, 2024
@adohe adohe force-pushed the refact_preview_cmd branch 2 times, most recently from aeae47b to d2cc3aa Compare April 12, 2024 14:14
@adohe adohe changed the title refact: preview&apply cmd implementation follow the command cmd pattern refactor: preview&apply cmd implementation follow the command cmd pattern Apr 12, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 4a08b0f into KusionStack:main Apr 14, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants