Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support os arch in mod push and ignore .git in the OCI artifact #1046

Merged
merged 1 commit into from Apr 18, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

support os arch in mod push and ignore .git in the OCI artifact

Which issue(s) this PR fixes:

Fixes #1014

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Apr 17, 2024

Pull Request Test Coverage Report for Build 8732058977

Details

  • 0 of 82 (0.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 55.493%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/client/client.go 0 4 0.0%
pkg/oci/client/push.go 0 11 0.0%
pkg/cmd/mod/mod_push.go 0 67 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/mod/mod_push.go 2 0.0%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8716967223: -0.1%
Covered Lines: 6718
Relevant Lines: 12106

💛 - Coveralls

@SparkYuan SparkYuan force-pushed the mod-push-osarch branch 2 times, most recently from cc58bb6 to e9b7f00 Compare April 17, 2024 11:25
pkg/cmd/mod/mod_push.go Outdated Show resolved Hide resolved
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 3df2a20 into KusionStack:main Apr 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: upgrade kusion mod push to build and upload multiple OS-arch modules.
3 participants