Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move module binary to KUSION_HOME by new path format #1062

Merged
merged 1 commit into from Apr 26, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Apr 22, 2024

Pull Request Test Coverage Report for Build 8846037647

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 54.83%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/mod/mod_push.go 0 1 0.0%
pkg/engine/api/generate/generator/generator.go 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/apply.go 7 47.96%
Totals Coverage Status
Change from base Build 8844999829: -0.03%
Covered Lines: 8815
Relevant Lines: 16077

💛 - Coveralls

liu-hm19
liu-hm19 previously approved these changes Apr 26, 2024
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan force-pushed the mod-push-osarch branch 2 times, most recently from 5179378 to 1dfc6c2 Compare April 26, 2024 08:09
@SparkYuan SparkYuan enabled auto-merge (squash) April 26, 2024 08:23
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 82c7c9a into KusionStack:main Apr 26, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants