Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update port forward for kusion apply #1063

Merged
merged 1 commit into from Apr 23, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the port-forwarding for kusion apply.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added this to the v0.11.1 milestone Apr 23, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan April 23, 2024 12:38
@liu-hm19 liu-hm19 self-assigned this Apr 23, 2024
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit fddd4d1 into KusionStack:main Apr 23, 2024
8 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8800524826

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 54.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/apply.go 0 1 0.0%
pkg/engine/operation/port_forward.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/port_forward.go 1 30.0%
pkg/cmd/apply/apply.go 7 48.15%
Totals Coverage Status
Change from base Build 8782173414: 0.004%
Covered Lines: 8800
Relevant Lines: 16034

💛 - Coveralls

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants