Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support spec as input #400

Merged
merged 10 commits into from
Jul 25, 2023
Merged

feat: support spec as input #400

merged 10 commits into from
Jul 25, 2023

Conversation

panshuai-ps
Copy link
Contributor

@panshuai-ps panshuai-ps commented Jul 21, 2023 •
edited by SparkYuan

What type of PR is this?

/kind feature

What this PR does / why we need it:

Kusion accepts spec as an input format in addition to KCL
close #396

Does this PR introduce a user-facing change?

NONE

@github-actions
Copy link

github-actions bot commented Jul 21, 2023 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@panshuai-ps panshuai-ps self-assigned this Jul 21, 2023
@panshuai-ps panshuai-ps linked an issue Jul 21, 2023 that may be closed by this pull request
Toolchain: Kusion supports spec as input #396
Closed
@panshuai-ps panshuai-ps added kind/feature Categorizes issue or PR as related to a new feature priority/critical-urgent P0, highest priority. Must be actively worked on as someone's top priority right now labels Jul 21, 2023
@panshuai-ps panshuai-ps added this to the 0.9.0 milestone Jul 21, 2023
@panshuai-ps panshuai-ps marked this pull request as draft July 21, 2023 07:03
@panshuai-ps panshuai-ps marked this pull request as ready for review July 21, 2023 09:05
@coveralls
Copy link

coveralls commented Jul 21, 2023 •
edited

Pull Request Test Coverage Report for Build 5651960723

  • 57 of 65 (87.69%) changed or added relevant lines in 5 files are covered.
  • 18 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.6%) to 72.352%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/apply/options.go 9 10 90.0%
pkg/cmd/spec/generator.go 10 12 83.33%
pkg/cmd/preview/options.go 29 34 85.29%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/cmd/apply/options.go 7 71.92%
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 5599705927: -0.6%
Covered Lines: 5095
Relevant Lines: 7042
💛 - Coveralls

SparkYuan
SparkYuan reviewed Jul 24, 2023
View reviewed changes
docs/cmd/en_US/kusion_apply.md Outdated Show resolved Hide resolved
docs/cmd/en_US/kusion_preview.md Outdated Show resolved Hide resolved
docs/cmd/zh_CN/kusion.md Outdated Show resolved Hide resolved
docs/cmd/zh_CN/kusion_preview.md Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
pkg/cmd/preview/options.go Show resolved Hide resolved
pkg/cmd/preview/options.go Outdated Show resolved Hide resolved
pkg/cmd/preview/preview.go Show resolved Hide resolved
SparkYuan
SparkYuan approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6bd6eaa into main Jul 25, 2023
4 checks passed
@SparkYuan SparkYuan deleted the spec-as-input branch July 25, 2023 03:00
@SparkYuan SparkYuan restored the spec-as-input branch July 25, 2023 03:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2023
@SparkYuan SparkYuan deleted the spec-as-input branch July 27, 2023 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

Assignees

@panshuai-ps panshuai-ps

Labels
kind/feature Categorizes issue or PR as related to a new feature priority/critical-urgent P0, highest priority. Must be actively worked on as someone's top priority right now
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Toolchain: Kusion supports spec as input
3 participants
@panshuai-ps @coveralls @SparkYuan