Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support some magic env parsers #473

Merged
merged 6 commits into from
Aug 22, 2023
Merged

feat: support some magic env parsers #473

merged 6 commits into from
Aug 22, 2023

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Aug 21, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support some magic env parsers:

  • SecretMagicEnvParser
  • RawMagicEnvParser

And, add corresponding unit tests.

@elliotxx elliotxx added this to the 0.9.0 milestone Aug 21, 2023
@elliotxx elliotxx self-assigned this Aug 21, 2023
@elliotxx elliotxx changed the title feat: support magic env parser feat: support some magic env parsers Aug 21, 2023
@elliotxx elliotxx changed the title feat: support some magic env parsers [WIP] feat: support some magic env parsers Aug 21, 2023
@elliotxx elliotxx linked an issue Aug 21, 2023 that may be closed by this pull request
Model: AppConfiguration model supports magic envs #474
Closed
@elliotxx elliotxx changed the title [WIP] feat: support some magic env parsers feat: support some magic env parsers Aug 21, 2023
@elliotxx elliotxx enabled auto-merge (squash) August 21, 2023 06:45
@coveralls
Copy link

coveralls commented Aug 21, 2023 •
edited

Pull Request Test Coverage Report for Build 5924577087

  • 63 of 69 (91.3%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.1%) to 70.849%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/workload/workload_generator.go 0 1 0.0%
pkg/generator/appconfiguration/generator/workload/magic_env_var.go 63 68 92.65%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/cmd/apply/options.go 7 71.92%
Totals Coverage Status
Change from base Build 5921582188: 0.1%
Covered Lines: 5342
Relevant Lines: 7540
💛 - Coveralls

@KusionStack KusionStack deleted a comment from elliotxx Aug 21, 2023
SparkYuan
SparkYuan approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit a4ea1a0 into KusionStack:main Aug 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@ffforest ffforest Awaiting requested review from ffforest

@panshuai-ps panshuai-ps Awaiting requested review from panshuai-ps

@healthjyk healthjyk Awaiting requested review from healthjyk

@adohe adohe Awaiting requested review from adohe

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Model: AppConfiguration model supports magic envs
3 participants
@elliotxx @coveralls @SparkYuan