Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: complete workload unit tests #475

Merged
merged 1 commit into from
Aug 21, 2023
Merged

test: complete workload unit tests #475

merged 1 commit into from
Aug 21, 2023

Conversation

elliotxx
Copy link
Contributor

What type of PR is this?

/kind test

What this PR does / why we need it:

Complete workload unit tests

@elliotxx elliotxx self-assigned this Aug 21, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Aug 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5924413890

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.8%) to 72.495%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/appconfiguration/generator/app_configurations_generator.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 5921582188: 1.8%
Covered Lines: 5419
Relevant Lines: 7475
💛 - Coveralls

adohe
adohe approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit ef88f2a into KusionStack:main Aug 21, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
@elliotxx elliotxx linked an issue Aug 22, 2023 that may be closed by this pull request
Test: Unit test for completing generator package #478
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@ffforest ffforest Awaiting requested review from ffforest

@panshuai-ps panshuai-ps Awaiting requested review from panshuai-ps

@healthjyk healthjyk Awaiting requested review from healthjyk

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Test: Unit test for completing generator package
3 participants
@elliotxx @coveralls @adohe