Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error with -w flag in kpm mode #538

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix compile error with -w flag in kpm mode

Which issue(s) this PR fixes:

Fixes #537

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Sep 12, 2023

Pull Request Test Coverage Report for Build 6181812295

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 74.122%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/generator/kcl/kcl_generator.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 72.03%
Totals Coverage Status
Change from base Build 6181016754: -0.04%
Covered Lines: 6267
Relevant Lines: 8455

💛 - Coveralls

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit a722c0c into KusionStack:main Sep 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
@SparkYuan SparkYuan deleted the fix-compile-with-wd-flag branch September 14, 2023 12:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: apply failed with -w flag
3 participants