Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aws secrets manager based secret store provider #623

Merged
merged 1 commit into from Dec 5, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Nov 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add aws secrets manager based secret store provider

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Nov 26, 2023
@coveralls
Copy link

coveralls commented Nov 26, 2023

Pull Request Test Coverage Report for Build 7087981691

  • 56 of 79 (70.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 75.05%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/aws/secretsmanager/secretsmanager.go 56 79 70.89%
Totals Coverage Status
Change from base Build 7087544280: 0.04%
Covered Lines: 6705
Relevant Lines: 8934

💛 - Coveralls

@adohe adohe force-pushed the add_aws_secret_provider branch 4 times, most recently from 43f8c2b to a27f0f3 Compare November 29, 2023 03:28
@adohe adohe changed the title WIP: add aws secrets manager based secret store provider feat: add aws secrets manager based secret store provider Nov 29, 2023
@adohe adohe added this to the 0.10.0 milestone Nov 29, 2023
@SparkYuan
Copy link
Member

Pull Request Test Coverage Report for Build 7027650607

  • 18 of 82 (21.95%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 74.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/aws/secretsmanager/secretsmanager.go 18 82 21.95%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 7017385861: -0.5%
Covered Lines: 6511
Relevant Lines: 8743

💛 - Coveralls

@adohe Please add additional test cases as the coverage is only 21.95% now

@adohe adohe force-pushed the add_aws_secret_provider branch 3 times, most recently from d2cecdf to faff0b2 Compare December 1, 2023 11:49
@ffforest ffforest linked an issue Dec 4, 2023 that may be closed by this pull request
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 079b7c1 into KusionStack:main Dec 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@adohe adohe deleted the add_aws_secret_provider branch January 8, 2024 03:31
@ffforest ffforest linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret generator development Feat: secret management support AWS Secrets Manager as backend.
5 participants