Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update secrets related types and interfaces #624

Merged
merged 1 commit into from Nov 27, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Nov 27, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

update secrets management related api typs and interfaces.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Nov 27, 2023
@coveralls
Copy link

coveralls commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7001097143

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 75.337%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 6980650200: 0.07%
Covered Lines: 6476
Relevant Lines: 8596

💛 - Coveralls

pkg/secrets/providers.go Outdated Show resolved Hide resolved
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 8108a56 into KusionStack:main Nov 27, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
@ffforest ffforest linked an issue Dec 4, 2023 that may be closed by this pull request
@adohe adohe deleted the update_secrets_apis branch January 8, 2024 03:31
@ffforest ffforest linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret generator development Feat: secret management support AWS Secrets Manager as backend.
4 participants