Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support setting KCL setting-files when building an Intent #649

Merged
merged 1 commit into from Dec 5, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: support setting KCL setting-files when building an Intent

Which issue(s) this PR fixes:

Fixes #646

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the fix-build branch 3 times, most recently from bdf02ce to 14c60e5 Compare December 5, 2023 06:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7097058571

  • 36 of 43 (83.72%) changed or added relevant lines in 6 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 75.031%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/util.go 11 14 78.57%
pkg/cmd/build/builders/kcl/kcl_builder.go 12 16 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/build/util.go 1 54.55%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7095680498: -0.02%
Covered Lines: 6722
Relevant Lines: 8959

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit f4d08f2 into KusionStack:main Dec 5, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Kusion build supports parsing kcl.yaml when building an Intent
3 participants