Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: getting workspace when running kusion build #653

Merged
merged 3 commits into from Dec 7, 2023
Merged

feat: getting workspace when running kusion build #653

merged 3 commits into from Dec 7, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

using workspace when running kusion build

Which issue(s) this PR fixes:

Fixes #648

Special notes for your reviewer:

Fix #638 can start, and use it as a test case.

@healthjyk healthjyk requested review from SparkYuan, NeverRaR, adohe and liu-hm19 and removed request for NeverRaR December 5, 2023 09:22
@healthjyk healthjyk self-assigned this Dec 5, 2023
@coveralls
Copy link

coveralls commented Dec 5, 2023 •
edited

Pull Request Test Coverage Report for Build 7101332590

  • 11 of 27 (40.74%) changed or added relevant lines in 3 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 74.887%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/app_configurations_generator.go 4 8 50.0%
pkg/cmd/build/util.go 6 18 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7098008312: -0.2%
Covered Lines: 6808
Relevant Lines: 9091
💛 - Coveralls

adohe
adohe reviewed Dec 5, 2023
View reviewed changes
pkg/cmd/build/util.go Outdated Show resolved Hide resolved
@adohe adohe self-assigned this Dec 5, 2023
@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Dec 5, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 5, 2023
liu-hm19
liu-hm19 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit cc705cc into KusionStack:main Dec 7, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2023
@healthjyk healthjyk deleted the kusion-build-use-workspace branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe left review comments

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

Assignees

@healthjyk healthjyk

@adohe adohe

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.10.0
4 participants
@healthjyk @coveralls @adohe @liu-hm19