Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add alicloud secrets manager based secret store provider #665

Merged
merged 2 commits into from Dec 14, 2023

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feat

What this PR does / why we need it:

This PR adds alicloud secrets manager based secret store provider and related unit test cases.

Which issue(s) this PR fixes:

Fixes #638

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 self-assigned this Dec 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7162354944

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 47 of 61 (77.05%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 74.904%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/alicloud/secretsmanager/secretsmanager.go 47 61 77.05%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 7139454523: 0.003%
Covered Lines: 6856
Relevant Lines: 9153

💛 - Coveralls

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit 4a15a1e into KusionStack:main Dec 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret management supports Alicloud Secrets Manager as backend
3 participants