Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update the struct of TerraformConfig #670

Merged
merged 1 commit into from Dec 12, 2023
Merged

refactor: update the struct of TerraformConfig #670

merged 1 commit into from Dec 12, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the struct of TerraformConfig, introduce type ProviderConfig.

@healthjyk healthjyk self-assigned this Dec 12, 2023
@coveralls
Copy link

coveralls commented Dec 12, 2023 •
edited

Pull Request Test Coverage Report for Build 7181071540

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 74.144%
Totals Coverage Status
Change from base Build 7177747000: 0.3%
Covered Lines: 6888
Relevant Lines: 9290
💛 - Coveralls

liu-hm19
liu-hm19 requested changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for the typo

pkg/apis/workspace/types.go Outdated Show resolved Hide resolved
liu-hm19
liu-hm19 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 7531425 into KusionStack:main Dec 12, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@healthjyk healthjyk deleted the terraform-config branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees

@healthjyk healthjyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19