Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use kubeConfig in extensions to init kubernetes runtime #672

Merged
merged 1 commit into from Dec 14, 2023
Merged

feat: use kubeConfig in extensions to init kubernetes runtime #672

merged 1 commit into from Dec 14, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

use kubeConfig in extensions to init kubernetes runtime.

@healthjyk healthjyk force-pushed the use-kubeconfig-intent branch 2 times, most recently from 035b534 to 37af048 Compare December 13, 2023 07:47
@coveralls
Copy link

coveralls commented Dec 13, 2023 •
edited

Pull Request Test Coverage Report for Build 7205327141

  • 33 of 40 (82.5%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 74.112%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/terraform_runtime.go 0 1 0.0%
pkg/engine/runtime/init/init.go 20 26 76.92%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 7204073011: -0.08%
Covered Lines: 6948
Relevant Lines: 9375
💛 - Coveralls

@healthjyk healthjyk self-assigned this Dec 14, 2023
liu-hm19
liu-hm19 reviewed Dec 14, 2023
View reviewed changes
pkg/engine/runtime/init/init.go Outdated Show resolved Hide resolved
pkg/engine/runtime/init/init.go Show resolved Hide resolved
liu-hm19
liu-hm19 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit efa145e into KusionStack:main Dec 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2023
@healthjyk healthjyk deleted the use-kubeconfig-intent branch December 27, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

Assignees

@healthjyk healthjyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19