Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support customize namespace through workspace config #704

Merged
merged 1 commit into from Dec 20, 2023
Merged

feat: support customize namespace through workspace config #704

merged 1 commit into from Dec 20, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 19, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

support customize namespace name through workspace config

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Dec 19, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 19, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7261267205

  • 22 of 24 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 74.35%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/namespace_generator.go 21 23 91.3%
Totals Coverage Status
Change from base Build 7247431380: 0.04%
Covered Lines: 7180
Relevant Lines: 9657
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 401821c into KusionStack:main Dec 20, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@adohe adohe deleted the feat_customize_namespace branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

Assignees

@SparkYuan SparkYuan

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adohe @coveralls @SparkYuan