Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opsRule doesn't work in CollaSet #706

Merged
merged 2 commits into from Dec 19, 2023
Merged

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

fix opsRule doesn't work in CollaSet and upgrade RuleSet to PodTransitionRule

Which issue(s) this PR fixes:

Fixes #684

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 7261462789

  • 24 of 25 (96.0%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 74.415%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/trait/ops_rule_generator.go 24 25 96.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7261310804: -0.02%
Covered Lines: 7187
Relevant Lines: 9658

💛 - Coveralls

@healthjyk healthjyk merged commit 816225b into KusionStack:main Dec 19, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@SparkYuan SparkYuan deleted the ops-rule branch December 20, 2023 03:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: refactor opsrule module and generator
3 participants