Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: re-pack basic api types for susitable iteration #710

Merged
merged 1 commit into from Dec 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 20, 2023

What type of PR is this?

What this PR does / why we need it:

re-pack basic api types for susitable code iteration

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 20, 2023
@coveralls
Copy link

coveralls commented Dec 20, 2023

Pull Request Test Coverage Report for Build 7283352328

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 74.401%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 7270635216: -0.03%
Covered Lines: 7199
Relevant Lines: 9676

💛 - Coveralls

@healthjyk healthjyk enabled auto-merge (squash) December 21, 2023 06:10
@healthjyk healthjyk merged commit e101055 into KusionStack:main Dec 21, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@adohe adohe deleted the refact_api_types branch December 21, 2023 06:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants