Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: secret generator add more comments #712

Merged
merged 1 commit into from Dec 21, 2023
Merged

chore: secret generator add more comments #712

merged 1 commit into from Dec 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 21, 2023

What type of PR is this?

What this PR does / why we need it:

secret generator add more comments

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@adohe adohe added the kind/optimization Code optimization label Dec 21, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7284615382

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 74.492%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 7284456423: 0.05%
Covered Lines: 7295
Relevant Lines: 9793
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adohe adohe merged commit cccee10 into KusionStack:main Dec 21, 2023
8 checks passed
@adohe adohe deleted the secret_generator_add_comments branch December 21, 2023 06:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees

@liu-hm19 liu-hm19

Labels
kind/optimization Code optimization
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adohe @coveralls @liu-hm19