Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use secret types in core v1 pkg #714

Merged
merged 1 commit into from Dec 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 21, 2023

What type of PR is this?

What this PR does / why we need it:

use secret types in core v1 pkg

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 21, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7286879957

  • 27 of 35 (77.14%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 74.508%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/azure/keyvault/keyvault.go 7 15 46.67%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/destroy/options.go 7 82.13%
Totals Coverage Status
Change from base Build 7285874075: -0.08%
Covered Lines: 7272
Relevant Lines: 9760

💛 - Coveralls

@healthjyk healthjyk merged commit 0413e0c into KusionStack:main Dec 21, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@adohe adohe deleted the use_core_v1_api_types branch December 21, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants