Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use project&stack types in core v1 pkg #715

Merged
merged 1 commit into from Dec 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 21, 2023

What type of PR is this?

What this PR does / why we need it:

use project&stack types in core v1 pkg

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 21, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 21, 2023
@adohe adohe changed the title update refactor: use project&stack types in core v1 pkg Dec 21, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7289298238

  • 142 of 185 (76.76%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 74.461%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/options.go 1 2 50.0%
pkg/cmd/build/util.go 7 8 87.5%
pkg/cmd/deps/options.go 3 4 75.0%
pkg/engine/runtime/terraform/terraform_runtime.go 2 3 66.67%
pkg/modules/generators/app_configurations_generator.go 0 1 0.0%
pkg/modules/generators/monitoring/monitoring_generator.go 3 4 75.0%
pkg/project/paths.go 105 142 73.94%
Totals Coverage Status
Change from base Build 7287470124: -0.05%
Covered Lines: 7257
Relevant Lines: 9746

💛 - Coveralls

@healthjyk healthjyk merged commit 8165d7a into KusionStack:main Dec 21, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@adohe adohe deleted the use_core_v1_api_types branch December 22, 2023 08:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants