Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customize namespace generator issue #721

Merged
merged 1 commit into from Dec 25, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 22, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix customize namespace generator issue

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/bug Something isn't working label Dec 22, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7307529037

  • 119 of 143 (83.22%) changed or added relevant lines in 11 files are covered.
  • 20 unchanged lines in 6 files lost coverage.
  • Overall coverage decreased (-0.09%) to 74.546%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/workload/job_generator.go 10 11 90.91%
pkg/modules/generators/accessories/database/database_generator.go 8 10 80.0%
pkg/modules/generators/app_configurations_generator.go 26 28 92.86%
pkg/modules/generators/workload/secret/secret_generator.go 23 27 85.19%
pkg/modules/generators/workload/network/ports_generator.go 1 7 14.29%
pkg/modules/generators/monitoring/monitoring_generator.go 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/accessories/database/database_generator.go 1 85.16%
pkg/modules/generators/workload/secret/secret_generator.go 1 92.59%
pkg/modules/generators/monitoring/monitoring_generator.go 2 74.47%
pkg/modules/generators/workload/network/ports_generator.go 2 54.76%
pkg/cmd/apply/options.go 7 71.94%
pkg/cmd/destroy/options.go 7 82.13%
Totals Coverage Status
Change from base Build 7298373321: -0.09%
Covered Lines: 7345
Relevant Lines: 9853

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit c1f0455 into KusionStack:main Dec 25, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@adohe adohe deleted the fix_namespace_issue branch January 8, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants