Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename SecretStoreFactory to SecretStoreProvider #738

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Jan 8, 2024

What type of PR is this?

What this PR does / why we need it:

refactor: rename SecretStoreFactory to SecretStoreProvider

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Jan 8, 2024
@adohe adohe added this to the 0.10.0 milestone Jan 8, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7442874740

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 76.9%

Totals Coverage Status
Change from base Build 7442689106: 0.08%
Covered Lines: 8602
Relevant Lines: 11186

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 687408f into KusionStack:main Jan 8, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2024
@adohe adohe deleted the update_secret_store_providers branch January 8, 2024 03:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants