Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: monitoring generator with workspace configuration #741

Merged
merged 3 commits into from Jan 10, 2024
Merged

refactor: monitoring generator with workspace configuration #741

merged 3 commits into from Jan 10, 2024

Conversation

ffforest
Copy link
Contributor

@ffforest ffforest commented Jan 9, 2024

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@ffforest ffforest added kind/feature Categorizes issue or PR as related to a new feature kind/enhancement labels Jan 9, 2024
@ffforest ffforest added this to the 0.10.0 milestone Jan 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7458979214

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 77.091%
Totals Coverage Status
Change from base Build 7447101539: -0.1%
Covered Lines: 8766
Relevant Lines: 11371
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 5eb12a8 into KusionStack:main Jan 10, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2024
@ffforest ffforest linked an issue Jan 11, 2024 that may be closed by this pull request
Feat: refactor monitor module and generator #685
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx Awaiting requested review from elliotxx

@adohe adohe Awaiting requested review from adohe

Assignees
No one assigned
Labels
kind/enhancement kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Feat: refactor monitor module and generator
3 participants
@ffforest @coveralls @SparkYuan