Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the bug of unexpected.git directory #758

Merged
merged 1 commit into from Jan 24, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix the bug of gitutil.GitCloneOrPull which generates the unexpected.git directory

Which issue(s) this PR fixes:

Fixes #757

Special notes for your reviewer:

Why using removing dirs is explained in Fixes #757

@healthjyk healthjyk self-assigned this Jan 24, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7637698742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 77.009%

Totals Coverage Status
Change from base Build 7567219680: 0.002%
Covered Lines: 8769
Relevant Lines: 11387

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit bc450c5 into KusionStack:main Jan 24, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@healthjyk healthjyk deleted the fix-init branch March 6, 2024 09:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kusion init --online failed
3 participants