Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add options sub-cmd for kusion #791

Merged
merged 1 commit into from Feb 6, 2024

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Feb 2, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR adds options sub-cmd for kusion root command and fix the wrong --help info.

For example, below is the previous --help info of kusion init:
image

And this is the result after the bug fix:
image

Which issue(s) this PR fixes:

Fixes #772

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added kind/bug Something isn't working kind/feature Categorizes issue or PR as related to a new feature labels Feb 2, 2024
@liu-hm19 liu-hm19 added this to the v0.11.0 milestone Feb 2, 2024
@liu-hm19 liu-hm19 self-assigned this Feb 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7754053399

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 77.02%

Totals Coverage Status
Change from base Build 7725905829: 0.01%
Covered Lines: 8771
Relevant Lines: 11388

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 99168ac into KusionStack:main Feb 6, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: add options as the sub-command for kusion root command
3 participants