Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no assignment of releaseVersion when version in buildInfo is empty #817

Merged
merged 1 commit into from Feb 27, 2024

Conversation

healthjyk
Copy link
Contributor

@healthjyk healthjyk commented Feb 23, 2024

What type of PR is this?

/kind bug

What this PR does / why we need it:

no assignment of releaseVersion when version in buildInfo is empty

Which issue(s) this PR fixes:

Fixes #818

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8016672036

Details

  • 0 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 76.862%

Files with Coverage Reduction New Missed Lines %
pkg/version/types.go 2 91.59%
pkg/cmd/destroy/options.go 7 81.86%
Totals Coverage Status
Change from base Build 7985663449: -0.04%
Covered Lines: 9072
Relevant Lines: 11803

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe self-assigned this Feb 27, 2024
@adohe adohe added kind/bug Something isn't working area/cli Categorizes an issue or PR as relevant to CLI. labels Feb 27, 2024
@adohe adohe added this to the v0.11.0 milestone Feb 27, 2024
@adohe adohe merged commit 308fc17 into KusionStack:main Feb 27, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 27, 2024
@healthjyk healthjyk deleted the fix-debug-version branch February 27, 2024 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Categorizes an issue or PR as relevant to CLI. kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: empty releaseVersion when executing go version with local-built kusion on windows
4 participants