refactor: workload, port and secret according to the new appConfig model #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split types in the v1/types.go to separate files to maintain consistency with the coding style of the rest of the code
SparkYuan
force-pushed
the
module-workload
branch
from
074b496
to
405ecc1
Compare
SparkYuan
force-pushed
the
module-workload
branch
4 times, most recently
from
0793d72
to
1e3d752
Compare
Pull Request Test Coverage Report for Build 8049141999Details
💛 - Coveralls |
the way of using namespace isn't changed and marked it as a todo
SparkYuan
force-pushed
the
module-workload
branch
from
1e3d752
to
c60d53c
Compare
healthjyk
approved these changes
Feb 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind refactor
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #773 #813
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: