Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename backend related configs in workspace to deprecated #839

Merged

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 8092655543

Details

  • 16 of 33 (48.48%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 74.195%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/backend/config.go 8 10 80.0%
pkg/workspace/validation.go 6 9 66.67%
pkg/workspace/util.go 0 12 0.0%
Totals Coverage Status
Change from base Build 8092458130: 0.03%
Covered Lines: 6866
Relevant Lines: 9254

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit fd0915c into KusionStack:main Feb 29, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 29, 2024
@healthjyk healthjyk deleted the mark-deprecated-worksapce-backend branch March 6, 2024 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants