Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update init cmd #863

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Mar 4, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR updates the kusion init command.

Which issue(s) this PR fixes:

Fixes #781 #783 #810 #820

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Mar 4, 2024

Pull Request Test Coverage Report for Build 8320929558

Details

  • 105 of 117 (89.74%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 73.54%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/scaffold/demo_loader.go 46 58 79.31%
Totals Coverage Status
Change from base Build 8320805186: 0.8%
Covered Lines: 6726
Relevant Lines: 9146

💛 - Coveralls

Copy link
Contributor

@healthjyk healthjyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but issues left

pkg/cmd/init/util/util.go Show resolved Hide resolved
pkg/scaffold/demo_loader.go Show resolved Hide resolved
pkg/scaffold/demo_loader.go Show resolved Hide resolved
@liu-hm19 liu-hm19 merged commit 3fdef61 into KusionStack:main Mar 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: kusion init supports the updated built-in templates for typical project initiation
3 participants