Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: workload generator add container dirs implementation #899

Merged
merged 1 commit into from Mar 12, 2024

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 11, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add container dirs implementation

Which issue(s) this PR fixes:

Fixes #674

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature area/cli Categorizes an issue or PR as relevant to CLI. labels Mar 11, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 11, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8227319460

Details

  • 27 of 31 (87.1%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 74.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/workload/workload_generator.go 27 31 87.1%
Totals Coverage Status
Change from base Build 8215284520: 0.1%
Covered Lines: 7585
Relevant Lines: 10248

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 86c0dc6 into KusionStack:main Mar 12, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/cli Categorizes an issue or PR as relevant to CLI. kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support using Dirs in Container to create volume and volumeMount
5 participants