Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: module lint test #917

Merged
merged 9 commits into from Mar 13, 2024
Merged

feat: module lint test #917

merged 9 commits into from Mar 13, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@coveralls
Copy link

coveralls commented Mar 13, 2024 •
edited

Pull Request Test Coverage Report for Build 8264656679

Details

  • 131 of 198 (66.16%) changed or added relevant lines in 5 files are covered.
  • 6 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.06%) to 73.268%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/util.go 0 1 0.0%
pkg/modules/interfaces.go 0 3 0.0%
pkg/modules/plugin.go 0 3 0.0%
pkg/modules/generators/app_configurations_generator.go 130 190 68.42%
Files with Coverage Reduction New Missed Lines %
pkg/modules/interfaces.go 1 0.0%
pkg/modules/generators/app_configurations_generator.go 2 71.77%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8259122382: -0.06%
Covered Lines: 7806
Relevant Lines: 10654
💛 - Coveralls

@SparkYuan SparkYuan force-pushed the main-moudle branch 2 times, most recently from 182b746 to 70c252c Compare March 13, 2024 12:30
@SparkYuan
fix: some uts
4cfbb09 
1. delete duplicate app config generator tests
2. fix util_test.go
3. comment module related e2e tests
@SparkYuan SparkYuan enabled auto-merge (squash) March 13, 2024 12:37
elliotxx
elliotxx approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 3e9561a into KusionStack:main Mar 13, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elliotxx elliotxx elliotxx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SparkYuan @coveralls @elliotxx @liu-hm19