Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mod push command impl #923

Merged
merged 1 commit into from Mar 18, 2024
Merged

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Mar 15, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

add mod push command impl

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

will add test cases in the future

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Mar 15, 2024
@adohe adohe added this to the v0.11.0 milestone Mar 15, 2024
@adohe adohe changed the title WIP: add mod push command impl feat: add mod push command impl Mar 15, 2024
@adohe adohe force-pushed the impl_mod_push_cmd branch 3 times, most recently from e537aeb to b9a6b95 Compare March 18, 2024 11:58
@coveralls
Copy link

coveralls commented Mar 18, 2024

Pull Request Test Coverage Report for Build 8326331634

Details

  • 32 of 375 (8.53%) changed or added relevant lines in 11 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.6%) to 61.008%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/oci/reference.go 0 1 0.0%
pkg/modules/proto/module_grpc.pb.go 0 2 0.0%
pkg/oci/client/tag.go 0 6 0.0%
pkg/oci/metadata/metadata.go 0 9 0.0%
pkg/oci/client/push.go 0 12 0.0%
pkg/oci/client/client.go 0 19 0.0%
pkg/util/gitutil/info.go 0 22 0.0%
pkg/util/executable/executable.go 8 39 20.51%
pkg/oci/sign_artifact.go 0 55 0.0%
pkg/cmd/mod/mod_push.go 23 209 11.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/mod/mod_push.go 1 13.43%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8325991978: -1.6%
Covered Lines: 7410
Relevant Lines: 12146

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 9ad97e4 into KusionStack:main Mar 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants