Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workspace storages. including local, oss, s3, mysql #925

Merged
merged 1 commit into from Mar 18, 2024
Merged

feat: add workspace storages. including local, oss, s3, mysql #925

merged 1 commit into from Mar 18, 2024

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@coveralls
Copy link

coveralls commented Mar 15, 2024 •
edited

Pull Request Test Coverage Report for Build 8320817819

Details

  • 276 of 645 (42.79%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.8%) to 70.939%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/storages/local.go 94 134 70.15%
pkg/workspace/storages/oss.go 58 152 38.16%
pkg/workspace/storages/s3.go 67 176 38.07%
pkg/workspace/storages/mysql.go 40 166 24.1%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 8320805186: -1.8%
Covered Lines: 7477
Relevant Lines: 10540
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 8b22ba9 into KusionStack:main Mar 18, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
@healthjyk healthjyk deleted the workspace-storages branch March 18, 2024 03:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@adohe adohe Awaiting requested review from adohe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19