Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update grpc interface #946

Merged
merged 2 commits into from Mar 19, 2024

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: update grpc interface

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the module-interface-patch branch 2 times, most recently from 5f93ddf to 122c572 Compare March 19, 2024 11:46
@SparkYuan SparkYuan enabled auto-merge (squash) March 19, 2024 11:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8342496023

Details

  • 6 of 27 (22.22%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 60.662%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/proto/module_grpc.pb.go 0 2 0.0%
pkg/modules/proto/module.pb.go 0 5 0.0%
pkg/modules/generators/app_configurations_generator.go 6 20 30.0%
Files with Coverage Reduction New Missed Lines %
pkg/modules/generators/app_configurations_generator.go 1 70.0%
Totals Coverage Status
Change from base Build 8342351361: -0.06%
Covered Lines: 7462
Relevant Lines: 12301

💛 - Coveralls

Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 1726f10 into KusionStack:main Mar 19, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants