Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate module logs into different files #949

Merged
merged 1 commit into from Mar 21, 2024

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Mar 20, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: separate module logs into different files

Which issue(s) this PR fixes:

Fixes #939

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 8355108219

Details

  • 10 of 43 (23.26%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 60.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/plugin.go 0 33 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 8353166944: -0.09%
Covered Lines: 7384
Relevant Lines: 12183

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) March 20, 2024 07:23
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit b3d65e6 into KusionStack:main Mar 21, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: module RPC log exposed to the Kusion cmd output
3 participants