Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some bugs #971

Merged
merged 2 commits into from
Mar 28, 2024
Merged

fix: some bugs #971

merged 2 commits into from
Mar 28, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes some bugs, including some typos and wrong hints of the cmd.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8461736426

Details

  • 4 of 13 (30.77%) changed or added relevant lines in 3 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 58.03%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/runtime/terraform/install.go 1 10 10.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/runtime/terraform/install.go 3 20.69%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
Totals Coverage Status
Change from base Build 8451425947: -0.1%
Covered Lines: 7360
Relevant Lines: 12683

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) March 28, 2024 03:26
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit b9cf0ae into KusionStack:main Mar 28, 2024
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants