Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getPodsToDelete(): delete the pods in ScaleInOpsLifecycleAdapter first #158

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

ColdsteelRail
Copy link
Collaborator

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #156".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.96%. Comparing base (dbbb7e3) to head (33d111d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #158   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          72       72           
  Lines        4731     4731           
=======================================
  Hits         3026     3026           
  Misses       1422     1422           
  Partials      283      283           
Flag Coverage Δ
unittests 63.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail force-pushed the fix-scaleIn-stuck-by-Ops branch 2 times, most recently from ac98d06 to cae5a7e Compare February 29, 2024 12:12
@ColdsteelRail ColdsteelRail force-pushed the fix-scaleIn-stuck-by-Ops branch 2 times, most recently from 559d57a to 376b397 Compare February 29, 2024 12:27
@ColdsteelRail ColdsteelRail changed the title filter pods not in OPS when scaleIn getPodsToDelete(): delete the pods in ScaleInOpsLifecycleAdapter first Feb 29, 2024
Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit d146ad4 into KusionStack:main Mar 1, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 1, 2024
@ColdsteelRail ColdsteelRail deleted the fix-scaleIn-stuck-by-Ops branch July 8, 2024 06:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Pod is unavailable after scale-in due to being stuck in PodOpsLifeCycle
2 participants