Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gracedelete/webhook): rewrite PodDeletionIndicationLabel value to… #167

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

cyh-ant
Copy link
Contributor

@cyh-ant cyh-ant commented Mar 19, 2024

… trigger reconcile of controllers, when reuse "kubectl delete"

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N

2. What is the scope of this PR (e.g. component or file name):

pkg/webhook/server/generic/pod/gracedelete/webhook.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Contains experimental features

The PodDeletionIndicationLabel value will be rewritten with current time UnixNano, when pod is deleted repeatedly. So the gracedelete controller could be re-triggered by 'kubectl delete'.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

… trigger reconcile of controllers, when reuse "kubectl delete"
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.03%. Comparing base (8087ea2) to head (13d7cee).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
+ Coverage   63.97%   64.03%   +0.06%     
==========================================
  Files          73       73              
  Lines        4711     4708       -3     
==========================================
+ Hits         3014     3015       +1     
+ Misses       1421     1418       -3     
+ Partials      276      275       -1     
Flag Coverage Δ
unittests 64.03% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wu8685 wu8685 merged commit abd79c5 into KusionStack:main Mar 19, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
2 participants