Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "Container Recreate" and "Pod Replace" in Batch #201

Closed
wants to merge 17 commits into from

Conversation

ColdsteelRail
Copy link
Collaborator

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ColdsteelRail ColdsteelRail requested a review from wu8685 May 11, 2024 08:55
@ColdsteelRail ColdsteelRail force-pushed the operationJob branch 2 times, most recently from 7b254e5 to bcf29c6 Compare May 11, 2024 10:00
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 74.15186% with 160 lines in your changes are missing coverage. Please review.

Project coverage is 67.23%. Comparing base (7f1e94d) to head (4fd7ba7).
Report is 2 commits behind head on main.

Current head 4fd7ba7 differs from pull request most recent head bb0b952

Please upload reports for the commit bb0b952 to get more accurate results.

Files Patch % Lines
...ontrollers/operationjob/operationjob_controller.go 62.43% 51 Missing and 17 partials ⚠️
pkg/controllers/operationjob/recreate.go 77.67% 32 Missing and 16 partials ⚠️
pkg/controllers/operationjob/replace.go 77.96% 16 Missing and 10 partials ⚠️
pkg/controllers/operationjob/event_handler.go 80.43% 7 Missing and 2 partials ⚠️
...g/controllers/operationjob/operationjob_manager.go 82.69% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   66.38%   67.23%   +0.84%     
==========================================
  Files          74       81       +7     
  Lines        5156     5775     +619     
==========================================
+ Hits         3423     3883     +460     
- Misses       1412     1525     +113     
- Partials      321      367      +46     
Flag Coverage Δ
unittests 67.23% <74.15%> (+0.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColdsteelRail ColdsteelRail force-pushed the operationJob branch 2 times, most recently from f7b04ce to d6fda1b Compare May 17, 2024 06:30
@ColdsteelRail ColdsteelRail force-pushed the operationJob branch 4 times, most recently from d25fdd3 to 4fd7ba7 Compare May 17, 2024 08:34
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力
1 participant