Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize: make alibaba_cloud_slb controller optional #80

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Conversation

WeichengWang1
Copy link
Collaborator

@WeichengWang1 WeichengWang1 commented Aug 31, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/controllers/add_alibaba_cloud_slb.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@WeichengWang1
Copy link
Collaborator Author

@wu8685 alibaba_cloud_slb controller shouldn't be a controller that will be started default, and this pr add an env switch, making it optional, ptal.

)

var defaultFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
PodOpsLifecycle: {Default: true, PreRelease: featuregate.Alpha},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These codes should be left.
AlibabaCloudSlb needs to be add in it with Default false.

@wu8685
Copy link
Collaborator

wu8685 commented Aug 31, 2023

@WeichengWang1 PTAL

Copy link
Collaborator

@wu8685 wu8685 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wu8685 wu8685 merged commit 8a081ee into main Aug 31, 2023
5 checks passed
@wu8685 wu8685 deleted the yibei-dev branch August 31, 2023 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants