-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor samplesheet #228
Refactor samplesheet #228
Conversation
…from_assembly' and to accept assembler as parameter
Codecov Report
@@ Coverage Diff @@
## dev #228 +/- ##
=======================================
Coverage 27.36% 27.36%
=======================================
Files 45 45
Lines 5314 5314
=======================================
Hits 1454 1454
Misses 3860 3860
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
📝 Add caution for samplesheet about absolute filepaths
@@ -29,7 +29,7 @@ process ALIGN_READS { | |||
path "*.version.txt" , emit: version | |||
|
|||
when: | |||
!meta.cov_from_spades |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these when
control flows should be handled within the calling workflow/subworkflow because I don't think it's unreasonable to think these modules might be reused for other subworkflows in the future. It also will probably allow defining that flow in a single place
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Although I'm not sure the when
directive can be used within a workflow definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ither workflow 🎨📝 Rename install.rst to installation.rst 🎨📝 Rename running-autometa-nextflow-workflow to autometa-nextflow-workflow 🐛🎨📝🔥 Fix typos and update entrypoint parameters in step-by-step tutorial
…allation to redirect new users
…Add to its own doc
…erly set.. (What a pesky bug this was to find...
Now samplesheet takes input
cov_from_assembly
instead ofcov_from_contig_headers
so in the future, other assembler contig header parsers may be easily added.