Merge pull request #163 from Kwenta/Q-7

Kwenta · Apr 30, 2023 · f23c670 · f23c670
2 parents 71661a2 + 4ce5f2b
commit f23c670
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -161,6 +161,12 @@ npm run compile
 npm run test
 ```
 
+4. Run specific test
+
+```
+forge test --fork-url $(grep ARCHIVE_NODE_URL_GOERLI_L2 .env | cut -d '=' -f2) --match-test TEST_NAME -vvv
+```
+
 > tests will fail if you have not set up your .env (see .env.example)
 
 ### Upgradability

diff --git a/src/interfaces/IEvents.sol b/src/interfaces/IEvents.sol
@@ -73,7 +73,7 @@ interface IEvents {
 
     event ConditionalOrderPlaced(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         bytes32 marketKey,
         int256 marginDelta,
         int256 sizeDelta,
@@ -93,7 +93,7 @@ interface IEvents {
 
     event ConditionalOrderCancelled(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         IAccount.ConditionalOrderCancelledReason reason
     );
 
@@ -109,7 +109,7 @@ interface IEvents {
 
     event ConditionalOrderFilled(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         uint256 fillPrice,
         uint256 keeperFee
     );

diff --git a/test/utils/ConsolidatedEvents.sol b/test/utils/ConsolidatedEvents.sol
@@ -50,7 +50,7 @@ contract ConsolidatedEvents {
 
     event ConditionalOrderPlaced(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         bytes32 marketKey,
         int256 marginDelta,
         int256 sizeDelta,
@@ -62,13 +62,13 @@ contract ConsolidatedEvents {
 
     event ConditionalOrderCancelled(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         IAccount.ConditionalOrderCancelledReason reason
     );
 
     event ConditionalOrderFilled(
         address indexed account,
-        uint256 conditionalOrderId,
+        uint256 indexed conditionalOrderId,
         uint256 fillPrice,
         uint256 keeperFee
     );